feat(starknet_os): remove the program from the OS runner inputs #5877
Conversation
|
This change is |
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file
branch
from
83d6363 to
1dbb071
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
e325490 to
728954b
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file
branch
from
1dbb071 to
d9d9e5f
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
728954b to
8fe7b87
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file
branch
from
d9d9e5f to
8688f92
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
8fe7b87 to
a1fd18f
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file
branch
from
8688f92 to
4061106
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
a1fd18f to
866c853
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file
branch
from
4061106 to
97825d7
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
866c853 to
af6a8b7
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file
branch
from
97825d7 to
2e6df53
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
af6a8b7 to
2d9c368
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file
branch
from
2e6df53 to
da89616
Compare
dorimedini-starkware
force-pushed
the
04-19-feat_apollo_starknet_os_program_add_test_contracts_add_dumper_in_cli
branch
from
0ae3e91 to
0e13d04
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
4098fbb to
8cc3b3f
Compare
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)
a discussion (no related file):
Previously, TzahiTaub (Tzahi) wrote…
Pease update
dorimedini-starkware
force-pushed
the
04-19-feat_apollo_starknet_os_program_add_test_contracts_add_dumper_in_cli
branch
from
0e13d04 to
8558852
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
8cc3b3f to
27e92bb
Compare
TzahiTaub
left a comment
TzahiTaub
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @nimrod-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
Waiting for it to pass
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)
a discussion (no related file):
Previously, TzahiTaub (Tzahi) wrote…
Waiting for it to pass
will require some changes (TODO cleanup logic is causing string mismatches, I think). will push a fix to this pr first; PTAL at the two preceding PRs for now (5945, 5946)
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
27e92bb to
dca637c
Compare
dorimedini-starkware
force-pushed
the
04-19-feat_apollo_starknet_os_program_add_test_contracts_add_dumper_in_cli
branch
from
8558852 to
9f22c4b
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
dca637c to
6ce1da8
Compare
TzahiTaub
left a comment
TzahiTaub
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)
TzahiTaub
left a comment
TzahiTaub
left a comment
There was a problem hiding this comment.
Reviewable status:
dorimedini-starkware
force-pushed
the
04-19-feat_apollo_starknet_os_program_add_test_contracts_add_dumper_in_cli
branch
from
9f22c4b to
03b37e8
Compare
dorimedini-starkware
force-pushed
the
04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs
branch
from
6ce1da8 to
394fb8f
Compare
TzahiTaub
left a comment
TzahiTaub
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status:
dorimedini-starkware
force-pushed
the
04-19-feat_apollo_starknet_os_program_add_test_contracts_add_dumper_in_cli
branch
from
03b37e8 to
6161f7d
Compare
dorimedini-starkware
changed the base branch from
04-19-feat_apollo_starknet_os_program_add_test_contracts_add_dumper_in_cli
to
main-v0.14.0
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 4 of 5 files at r3, 1 of 1 files at r5, 1 of 1 files at r7, 7 of 7 files at r8, all commit messages.
Reviewable status:
No description provided.